Skip to content

feat: new credit settings page#6604

Merged
michelleinez merged 3 commits intomainfrom
CP-2430
Jan 29, 2026
Merged

feat: new credit settings page#6604
michelleinez merged 3 commits intomainfrom
CP-2430

Conversation

@michelleinez
Copy link
Contributor

No description provided.

@michelleinez
Copy link
Contributor Author

image

@mcstover mcstover requested a review from a team January 29, 2026 00:36
</template>

<kv-default-wrapper>
<div class="row">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the page you've setup looks nice. We should implement the white block backgrounds on each section to better match the existing settings index, email, security and saved search pages.

Please follow this paradigm:
Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Yeah this does look a lot better.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note the alignment of the cards across both columns...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcstover not sure I understand what you're asking for re: alignment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have 2 columns and both use the boxed backgrounds, the tops of them should align when side by side like on the security and login page.

@michelleinez michelleinez requested a review from mcstover January 29, 2026 00:55
Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@michelleinez michelleinez merged commit 4d6b2ef into main Jan 29, 2026
5 checks passed
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.54.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants